Filer action window flickers

Risc OS 5.18 Iyonix flashed.

If you start a filer action copy and then place another window over the filer action window, then the contents of that window flicker at the position that is over the filename of the filer action window below.

Have just tested this and I think you’re slightly wrong about the effects. It looks to me as though the area that is redrawn (of the top window) corresponds to the position of the Filer_Action window’s title bar.

I’m guessing this is to do with how the title bar update is implemented. Filer_Action calls the RISC_OSLib function win_settitle, which in turn calls Wimp_ForceRedraw.

I note that the nested wimp has a ForceRedraw extension available to specifically redraw a window’s title bar, might be worth seeing if this cures the flicker.

Here’s a quick fix, I’ll try and get time to add this to the latest source and check it in later.

Add this function to actionwind.c:

static void set_title(wimp_w handle, char *title) {
  wimp_winfo winfo;
  winfo.w = handle;
  if (_swix(Wimp_GetWindowInfo, _IN(1), ((unsigned int)&winfo) | 1) == NULL) {
    strcpy(winfo.info.title.indirecttext.buffer, title);
  }
  _swix(Wimp_ForceRedraw, _INR(0,2), handle, 0x4B534154, 3);
}

And change all calls to

win_settitle()

set_title()

Of course this depends on the nested wimp but I don’t think that’s a problem.

I’d just like to add that it took me 10 times as long to get this post to display properly on this forum as it took to actually write the code. Can’t we please have a sensible forum system, and maybe even a wiki that doesn’t require javascript to contribute? I’ve lost count of the number of times I’ve gone to add something to the wiki, only to realise I can’t edit it from a RISC OS machine.

For the record, I’ve now committed this fix to the cvs.