RISC OS Open
Safeguarding the past, present and future of RISC OS for everyone
ROOL
Home | News | Downloads | Bugs | Bounties | Forum | Documents | Photos | Contact us
Account

Previous|Next

  • Tickets
  • » Ticket #169

Ticket #169 (Fixed)Sat Mar 15 14:23:34 UTC 2008

After doing an edit, you are always returned to the first page of a thread.

Reported by: James Lampard (51) Severity: Normal
Part: Web site: Beast (forum engine; forum pages) Release: 3rd public site release
Milestone: 3rd public site release completed Status Fixed

Details by James Lampard (51):

When you edit a post and press the save button, the forum returns you to the first page of the thread, rather than the one containing your post. This is annoying.

Changelog:

Modified by Trevor Johnson (329) Sat, January 15 2011 - 00:59:13 GMT

A few notes on this:
<ol><li>Edit post->cancel returns to the topic, with no page or post values passed in the URL</li>
<li>Edit post->Save returns to the topic with correct post value but incorrect page value (always page 1?) in the URL. Manually editing the URL to the appropriate page no. of the thread correctly returns to the edited post. (It’s not suggested that this is a particularly workable solution, although it could be quicker than clicking on the correct page no. and page down – which is what we’re all currently doing – just remember to make a mental note of the page no. before you edit!)</li>
Is the page error in app/views/posts/edit.rhtml, app/views/posts/edit.rjsedit.rjs*, app/views/posts/update.rjs* or elsewhere?

Modified by Trevor Johnson (329) Sat, January 15 2011 - 01:00:01 GMT

FFS couldn’t that have been presented as intended, please?

Modified by Trevor Johnson (329) Sat, January 15 2011 - 01:00:47 GMT

OK, I forgot the </ol> but all the same…

Modified by Trevor Johnson (329) Sat, February 26 2011 - 21:57:20 GMT

And clicking ‘Cancel’ after ‘Edit post’ simply returns to the start of the thread, without passing a page value parameter. The expected action might be to return to the previous page viewed (with a specific post link, if that was previously in the URL) or to the specific post cancelled (i.e. desired action after ‘Edit’ + ‘Save’).

Modified by Andrew Hodgkinson (6) Wed, March 16 2011 - 19:53:34 GMT

  • Milestone changed from Unspecified to Batch Three code release completed
  • Release changed from Unspecified to 3rd public site release

Modified by Andrew Hodgkinson (6) Wed, March 16 2011 - 19:54:55 GMT

  • Milestone changed from Batch Three code release completed to 3rd public site release completed

Oops!

Modified by Trevor Johnson (329) Mon, July 22 2013 - 15:18:47 GMT

That’s <a href=“https://www.riscosopen.org/tracker/repository/file/rool/rails/beast/trunk/app/views/posts/edit.rhtml”>app/views/posts/edit.rhtml</a>. N.B. <a href=“https://www.riscosopen.org/tracker/repository/changesets/308”>edit.rjs is no more</a>, <a href=“https://www.riscosopen.org/tracker/repository/changesets/310”>ditto update.rjs</a>.

Modified by Trevor Johnson (329) Mon, July 22 2013 - 15:20:24 GMT

Edit: that’s app/views/posts/edit.rhtml. N.B. edit.rjs is no more, ditto update.rjs.

Modified by Andrew Hodgkinson (6) Fri, August 30 2013 - 06:58:53 GMT

  • Status changed from Open to Fixed

Finally fixed in Changeset #444.

  • Comment on, or change status of, this ticket

Previous|Next

Search tickets

Social

Follow us on and

ROOL Store

Buy RISC OS Open merchandise here, including SD cards for Raspberry Pi and more.

Donate! Why?

Help ROOL make things happen – please consider donating!

RISC OS IPR

RISC OS is an Open Source operating system owned by RISC OS Developments Ltd and licensed primarily under the Apache 2.0 license.

Options

  • Tickets
  • New ticket
  • Milestones
  • Subversion: Changesets
  • Subversion: Browse
  • CVS: Revisions
  • CVS: Browse
  • Search

RSS feeds Rss

  • Tickets
  • Everything!
  • More feeds...
Site design © RISC OS Open Limited 2018 except where indicated
The RISC OS Open Collaboa theme is distantly based on the Collaboa default layout

Valid XHTML 1.0  |  Valid CSS

Powered by Collaboa
This site runs on Rails

Hosted by Arachsys