Ticket #203 (Fixed)Thu Apr 30 08:25:20 UTC 2009
Wimp_ResizeIcon uses -1 to represent the icon bar rather than the expected -2 as used by other calls
| Reported by: | Jeff Doggett (257) | Severity: | Normal |
| Part: | RISC OS: Module | Release: | |
| Milestone: | Status | Fixed |
Details by Jeff Doggett (257):
The SWI Wimp_ResizeIcon uses -1 in R0 for the icon bar. Most other calls use -2.
The code is:
SWIWimp_ResizeIcon
MyEntry “ResizeIcon”
I would suggest changing it to:
SWIWimp_ResizeIcon
MyEntry “ResizeIcon”
This uses fewer bytes than the expected:
CMP R0,#nullptr CMPNE R0,#nullptr2Changelog:
Modified by James Lampard (51) Fri, May 01 2009 - 12:36:25 GMT
This has come up before: http://groups.google.co.uk/group/comp.sys.acorn…
In “The desktop” chapter of PRM5a it specifically says that for Wimp_ResizeIcon -1 means the Iconbar.
Personally I believe this to be a typo. With old versions of the wimp any negative value is considered to be the iconbar, so it didn’t matter whether you used -1 or -2. When the wimp was fixed for 32bit it was changed to only recognise -1.
Modified by Trevor Johnson (329) Mon, January 24 2011 - 15:24:32 GMT
So is this a ‘WontFix’ candidate?
Modified by Andrew Hodgkinson (6) Mon, March 14 2011 - 23:19:10 GMT
- Milestone changed from 2nd public site release completed to Unspecified
- Release changed from 2nd public site release to Unspecified
Modified by Sprow (202) Fri, May 03 2013 - 21:11:11 GMT
- Status changed from Open to Fixed
To put an end to 4 years of indecision I flipped a coin and have changed (Wimp 5.24) to accept the more natural -2 as well as -1.
Of course, your program should use -1 for maximum compatibility (with versions of the Wimp in RISC OS 5.00 to present).
Another point of view is that all RISC OS 5 supporting hardware is still supported by RISC OS 5, so simply upgrade the OS and have a party.
