Ticket #284 (WorksForMe)Wed May 04 23:09:27 UTC 2011
Please create wiki page or I'll pester you some more
| Reported by: | Martin Bazley (331) | Severity: | Minor |
| Part: | Web site: Instiki (documentation Wiki) | Release: | 3rd public site release |
| Milestone: | 3rd public site release completed | Status | WorksForMe |
Details by Martin Bazley (331):
I went to the wiki to read the PRMs.
I was looking for OS_Byte, and, wonder of wonders, section 1 was complete and had a section invitingly titled “OS_Byte and OS_Word”. So I clicked on that.
I was looking for reason code 121, so I clicked on “Reason codes”. This, rather bizarrely, told me I must log in before I could continue. So I did.
Then I was confronted by a big green box proclaiming the following:
Page “OS_Byte+Introduction” does not exist. Please create it now, or hit the “back” button in your browser.
A brief glance at the URL bar was enough to tell me exactly why. A rogue + had not been replaced.
Well, I obeyed the instruction to go back, and in due course discovered that although the # links had not been updated, the main one had, which came to the same thing in the end.
Inconveniently, though, the wiki still wanted me to feed it.
The big green box is still there as I type, still yelling at me every time I visit any URL below ‘Documents’, regardless of what I’m actually looking at.
Can somebody make it go away?
Changelog:
Modified by Jeffrey Lee (213) Fri, May 06 2011 - 12:46:40 GMT
I’ve fixed the broken links on the OS_Byte/OS_Word page. However that’s just an introduction page, so you’ll be wanting this page to see what each reason code actually does:
https://www.riscosopen.org/wiki/documentation/s…
The big green box is still there as I type, still yelling at me every time I visit any URL below ‘Documents’, regardless of what I’m actually looking at.
So you’re saying that if you visit a wiki page which doesn’t exist, then no matter which page you visit afterwards, it will always have that ‘this page does not exist’ message at the top? Which browser are you using? Everything seems to be fine for me with IE 8 (Although IE is a bad choice, since it stalls for ages when opening wiki pages with lots of “linked from” links, like the main PRM index page)
Modified by Andrew Hodgkinson (6) Fri, May 13 2011 - 08:20:24 GMT
The regexp that tried to patch all the hundreds (thousands?) of broken links from the old Wiki and invalid assumptions about link formatting wasn’t perfect and some unusual formatting examples are bound to have slipped through the net.
As for the message in the green box:
1. It’s most likely a cookies fault in your browser. Try clearing cookies; I suspect the message will go away.
2. If not, then it could be a Hub integration fault. It may be that the Hub flash message is being counted as part of the cacheable page and the message ended up incorporated in a cache fragment, but then other people would see it when they visited the same pages as you. If (1) doesn’t fix the fault, please post a URL of an example page where you see the green message so I can check the cache to test this hypothesis. Thanks!
Modified by Martin Bazley (331) Mon, September 19 2011 - 20:21:03 GMT
Oops, I totally forgot I’d created this ticket!
Anyway, I just tried again. I entered a nonsense URL, which produced a green box with a creation demand in it. I then clicked on the ‘Documents’ link in the navigation bar (this being the only immediately obvious way out), and, sure enough, above the wiki index was a green box still ordering me to create the same page I’d just left behind.
I cleared my cookies and it went away. Unfortunately it also logged me out, which seems to be all that is really necessary to make it vanish (that’s how I fixed it the first time).
Why does this box rely on cookies? Surely they’re entirely inappropriate for displaying information which is only supposed to apear on one specific page when it is loaded? You might as well use them for displaying a 404 message! Shouldn’t the ‘create new page’ template be amended instead?
Modified by Andrew Hodgkinson (6) Tue, September 03 2013 - 07:05:18 GMT
- Status changed from Open to WorksForMe
These so-called “flash” messages are stored in the session for the Wiki and, since the server side is stateless, that’s stored in a cookie on your computer. You need to have a think about the order of events in the HTTP request/response model that the Web relies upon to realise why this sort of thing is necessary.
- http://stackoverflow.com/questions/7331202/where-are-flash-messages-stored
- “https://www.riscosopen.org/content/documents/privacy”
The flash message is output as part of the page template, else you’d never see it! It might need to be shown when the same page is sent back as a result of a form submission; but it might also need to be shown when an entirely new page is shown as a result of an HTTP 30x redirection, possibly a chain of several, which means several fetches.
I cannot replicate the issue I’m afraid – if I enter a nonsense URL I get the “create page” form complete with green box, but if I click on the Documents entry (or indeed any other entry) in the navigation bar, it goes away. So I’m having to close this as WorksForMe – it seems pretty minor anyway – if you really, really think it needs further investigation then please comment on the ticket and I’ll look into it again.
Modified by Andrew Hodgkinson (6) Tue, September 03 2013 - 07:05:41 GMT
…or rather, https://www.riscosopen.org/content/documents/privacy !
