RISC OS Open
A fast and easily customised operating system for ARM devices
ROOL
Home | News | Downloads | Bugs | Bounties | Forum | Documents | Photos | Contact us
Account

Previous|Next

  • Tickets
  • » Ticket #398

Ticket #398 (Fixed)Tue Dec 02 20:54:40 UTC 2014

SpriteExtend fails if plotting from a non-existant file

Reported by: Rick Murray (539) Severity: Normal
Part: RISC OS: Module Release:
Milestone: Status Fixed

Details by Rick Murray (539):

A brief look at the source indicates that SpriteExtend, if called via JPEG_PlotFileScaled, should return an appropriate error if the file given does not exist.

This is not the case.

SYS “JPEG_PlotFileScaled”, “bogusfilename”, 0, 0, 0, 3

The result is:

Internal error: branch through zero

Additionally, this error percolates up to a task that calls this SWI (causing that to fail with the branch through zero reported by its error handler).

FIX :

File …mixed.RiscOS.Sources.Video.Render.SprExtend.Sources.SWIs

Line 596 (two below “jpegplotfilescaled_nofile”) says:

Pull “R1-R4”

This does not match what was previously saved (in line 542).

Change to:

Pull “R1-R5”

A standalone version of SpriteExtend built. The above SWI call now correctly returns the error:

File ‘bogusfilename’ not found

I’ve just had a look, it seems as if the other SWIs (JPEG_PlotFileTransformed and JPEG_FileInfo) are okay and correctly report nonexistent files.

Changelog:

Modified by Sprow (202) Sat, December 06 2014 - 08:52:27 GMT

  • Status changed from Open to Fixed

Committed as SprExtend-1_64. Thanks!

  • Comment on, or change status of, this ticket

Previous|Next

Search tickets

Social

Follow us on and

ROOL Store

Buy RISC OS Open merchandise here, including SD cards for Raspberry Pi and more.

Donate! Why?

Help ROOL make things happen – please consider donating!

RISC OS IPR

RISC OS is an Open Source operating system owned by RISC OS Developments Ltd and licensed primarily under the Apache 2.0 license.

Options

  • Tickets
  • New ticket
  • Milestones
  • Subversion: Changesets
  • Subversion: Browse
  • CVS: Revisions
  • CVS: Browse
  • Search

RSS feeds Rss

  • Tickets
  • Everything!
  • More feeds...
Site design © RISC OS Open Limited 2018 except where indicated
The RISC OS Open Collaboa theme is distantly based on the Collaboa default layout

Valid XHTML 1.0  |  Valid CSS

Powered by Collaboa
This site runs on Rails

Hosted by Arachsys